pkg/steps/clusterinstall/template: Add LEASED_RESOURCE parameter #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd attempted to consume this as an environment variable in 00ebab1 (pkg/steps/clusterinstall/template: Get region from Boskos lease, 2020-12-11, openshift#1527), but it's failing in CI with [1]: 2020/12/15 18:04:36 Running pod e2e-aws-upgrade Installing from initial release registry.svc.ci.openshift.org/ocp/release:4.5.23 /bin/bash: line 59: LEASED_RESOURCE: unbound variable With this commit, I'm making it a template parameter, so it will be filled in by Go template expansion (and never be an environment variable within the test pod). [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.5-to-4.6/1338903713728696320#1:build-log.txt%3A29
openshift-ci-robot
added
the
approved
Member
Author
|
Precedent I'm following for another parameter: $ git --no-pager grep CLUSTER_NETWORK_TYPE pkg/steps/clusterinstall/template.go
pkg/steps/clusterinstall/template.go:- name: CLUSTER_NETWORK_TYPE
pkg/steps/clusterinstall/template.go: network_type="${CLUSTER_NETWORK_TYPE-}" |
AlexNPavel
approved these changes
Dec 15, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexNPavel, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd attempted to consume this as an environment variable in 00ebab1 (#1527), but it's failing in CI with:
With this commit, I'm making it a template parameter, so it will be filled in by Go template expansion (and never be an environment variable within the test pod).